[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tcg: Use memset for large vector byte replication
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] tcg: Use memset for large vector byte replication |
|
Date: |
Wed, 16 Dec 2020 08:28:59 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/15/20 5:38 PM, Philippe Mathieu-Daudé wrote:
> BTW (nitpicking) I'd rewrite the epilogue as:
>
> if (!in_32) {
> tcg_temp_free_i32(t_val);
> }
> tcg_temp_free_ptr(t_size);
>
> tcg_temp_free_ptr(t_ptr);
> return;
>
> t_val first, because the !in_32 allocs are few lines earlier,
> t_ptr last because allocated in prologue, so keep close to
> 'return'. Matter of taste ;)
Yah sure, you bettcha. Queued with this.
r~