Re: [PATCH 00/11] target/mips/mips-defs: Simplify ISA definitions

[Jiaxun Yang]

在 2020/12/16 21:43, Philippe Mathieu-Daudé 写道:
> As we don't need to duplicate 32/64-bit ISA defititions,
>
> this series remove the duplicated 64-bit variants,
>
> simplifying the overall.

Thanks, that makes things much more clear!

> Changes done automatically with my editor using "find
>
> and replace".
>
>
>
> While the 'ISA_MIPS_Rx' form is shorter than 'ISA_MIPS_RELx',
>
> which one is the clearer?

I'd perfer Rx to keep consistent with wording elsewhere.

Thanks.

- Jiaxun

> Regards,
>
>
>
> Phil.
>
>
>
> Philippe Mathieu-Daudé (11):
>
>    target/mips/mips-defs: Reorder CPU_MIPS5 definition
>
>    target/mips/mips-defs: Use ISA_MIPS3 for ISA_MIPS64
>
>    target/mips/mips-defs: Use ISA_MIPS32R2 definition to check Release 2
>
>    target/mips/mips-defs: Use ISA_MIPS32R3 definition to check Release 3
>
>    target/mips/mips-defs: Use ISA_MIPS32R5 definition to check Release 5
>
>    target/mips/mips-defs: Use ISA_MIPS32R6 definition to check Release 6
>
>    target/mips/mips-defs: Rename ISA_MIPS32 as ISA_MIPS_R1
>
>    target/mips/mips-defs: Rename ISA_MIPS32R2 as ISA_MIPS_R2
>
>    target/mips/mips-defs: Rename ISA_MIPS32R3 as ISA_MIPS_R3
>
>    target/mips/mips-defs: Rename ISA_MIPS32R5 as ISA_MIPS_R5
>
>    target/mips/mips-defs: Rename ISA_MIPS32R6 as ISA_MIPS_R6
>
>
>
>   target/mips/internal.h     |   8 +-
>
>   target/mips/mips-defs.h    |  40 +--
>
>   hw/mips/boston.c           |   2 +-
>
>   linux-user/elfload.c       |   2 +-
>
>   linux-user/mips/cpu_loop.c |   6 +-
>
>   target/mips/cp0_helper.c   |  18 +-
>
>   target/mips/cp0_timer.c    |   4 +-
>
>   target/mips/cpu.c          |  12 +-
>
>   target/mips/fpu_helper.c   |   4 +-
>
>   target/mips/tlb_helper.c   |   6 +-
>
>   target/mips/translate.c    | 620 ++++++++++++++++++-------------------
>
>   11 files changed, 357 insertions(+), 365 deletions(-)