[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG b
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds |
|
Date: |
Wed, 16 Dec 2020 09:25:57 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/16/20 9:22 AM, Paolo Bonzini wrote:
> On 16/12/20 16:13, Richard Henderson wrote:
>>> @@ -71,7 +71,7 @@ foreach d : [
>>> input: meson.project_source_root() / 'trace-events',
>>> command: [ tracetool, '--group=root',
>>> '--format=@0@'.format(d[1]), '@INPUT@' ],
>>> capture: true)
>>> - specific_ss.add(gen)
>>> + specific_ss.add(when: 'CONFIG_TCG', if_true: gen)
>>> endforeach
>>
>> Sure, unless it makes more sense to conditionalize the entire loop, so that
>> those targets aren't even created?
>
> The targets exist but the files won't be created (the rules will be in
> build.ninja but they'll be orphan).
Yes, I get that. So... is there a reason for them to be there, when it seems
just as easy for them not to be?
r~