[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/7] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT |
|
Date: |
Wed, 16 Dec 2020 17:49:30 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/16/20 3:25 AM, Jiaxun Yang wrote:
> Seems useless....
Indeed, introduced in 051c190bce5 ("MIPS: Initial support of
fulong mini pc (machine construction)") but never used.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> hw/mips/fuloong2e.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
> index 9b0eb8a314..055b99e378 100644
> --- a/hw/mips/fuloong2e.c
> +++ b/hw/mips/fuloong2e.c
> @@ -48,8 +48,6 @@
> #include "sysemu/reset.h"
> #include "qemu/error-report.h"
>
> -#define DEBUG_FULOONG2E_INIT
> -
> #define ENVP_PADDR 0x2000
> #define ENVP_VADDR cpu_mips_phys_to_kseg0(NULL, ENVP_PADDR)
> #define ENVP_NB_ENTRIES 16
>
- [PATCH 0/7] hw/mips/fuloong2e fixes, Jiaxun Yang, 2020/12/15
- [PATCH 1/7] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT, Jiaxun Yang, 2020/12/15
- Re: [PATCH 1/7] hw/mips/fuloong2e: Remove define DEBUG_FULOONG2E_INIT,
Philippe Mathieu-Daudé <=
- [PATCH 2/7] hw/mips/fuloong2e: Relpace fault links, Jiaxun Yang, 2020/12/15
- [PATCH 4/7] hw/pci-host/bonito: Fixup pci.lomem mapping, Jiaxun Yang, 2020/12/15
- [PATCH 3/7] hw/pci-host/bonito: Fixup IRQ mapping, Jiaxun Yang, 2020/12/15
- [PATCH 7/7] hw/mips/fuloong2e: Add highmem support, Jiaxun Yang, 2020/12/15
- [PATCH 5/7] hw/mips/fuloong2e: Remove unused env entry, Jiaxun Yang, 2020/12/15
- [PATCH 6/7] hw/mips/fuloong2e: Correct cpuclock env, Jiaxun Yang, 2020/12/15