[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/11] qapi/introspect.py: add preliminary type hint annot
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 05/11] qapi/introspect.py: add preliminary type hint annotations |
|
Date: |
Thu, 17 Dec 2020 08:00:49 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> On 12/16/20 2:51 AM, Markus Armbruster wrote:
>> Is it too late to delay the introduction of type hints until after
>> the
>> data structure cleanups?
>> If yes, I have to spend more time replying below.
>>
>
> No, I re-ordered the series again to delay typing until the end, or
> close to it.
Thanks!
> Though I abandoned plans to slacken List[...] inputs to Iterable[...]
> or Sequence[...] like I had mentioned; I think it could still be done,
> but it's fine to just use List[...] for the inputs for now. We can
> worry about optimizing type flexibility later, I think.
Shouldn't be a problem now I know what to expect.
> Let's just get the dog hunting at all first.
Yes.