Re: [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI

[Laurent Vivier]

Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit :
> 64-bit MIPS targets lost setup_frame() during the refactor in commit
> 8949bef18b9. Restore it declaring TARGET_ARCH_HAS_SETUP_FRAME, to be
> able to build the o32 ABI target.
> 
> Fixes: 8949bef18b9 ("linux-user: move mips/mips64 signal.c parts to mips 
> directory")
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/mips64/target_signal.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/linux-user/mips64/target_signal.h 
> b/linux-user/mips64/target_signal.h
> index 799f7a668cd..f1f0ed7f706 100644
> --- a/linux-user/mips64/target_signal.h
> +++ b/linux-user/mips64/target_signal.h
> @@ -67,4 +67,8 @@ typedef struct target_sigaltstack {
>  #define TARGET_MINSIGSTKSZ    2048
>  #define TARGET_SIGSTKSZ       8192
>  
> +#if defined(TARGET_ABI_MIPSO32)
> +/* compare linux/arch/mips/kernel/signal.c:setup_frame() */
> +#define TARGET_ARCH_HAS_SETUP_FRAME
> +#endif
>  #endif /* MIPS64_TARGET_SIGNAL_H */
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>