[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/20] migration: Replace migration's JSON writer by the gene
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [PATCH 16/20] migration: Replace migration's JSON writer by the general one |
|
Date: |
Thu, 17 Dec 2020 10:32:22 +0000 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Markus Armbruster (armbru@redhat.com) wrote:
> "Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
>
> > * Markus Armbruster (armbru@redhat.com) wrote:
> >> Commit 8118f0950f "migration: Append JSON description of migration
> >> stream" needs a JSON writer. The existing qobject_to_json() wasn't a
> >> good fit, because it requires building a QObject to convert. Instead,
> >> migration got its very own JSON writer, in commit 190c882ce2 "QJSON:
> >> Add JSON writer". It tacitly limits numbers to int64_t, and strings
> >> contents to characters that don't need escaping, unlike
> >> qobject_to_json().
> >>
> >> The previous commit factored the JSON writer out of qobject_to_json().
> >> Replace migration's JSON writer by it.
> >>
> >> Cc: Juan Quintela <quintela@redhat.com>
> >> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >
> > (Copying in Alex)
> >
> > This looks OK to me, so:
> >
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >
> > but, can I just check, have you checked scripts/analyze-migration.py is
> > still happy with the output?
>
> Good point. I just did, following instructions in
> docs/devel/migration.rst. It prints stuff and succeeds. Anything else
> you'd like me to try?
If it's happy, I'm happy.
Dave
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH 01/20] hmp: Simplify how qmp_human_monitor_command() gets output, (continued)
- [PATCH 01/20] hmp: Simplify how qmp_human_monitor_command() gets output, Markus Armbruster, 2020/12/11
- [PATCH 11/20] Revert "qobject: let object_property_get_str() use new API", Markus Armbruster, 2020/12/11
- [PATCH 17/20] json: Use GString instead of QString to accumulate strings, Markus Armbruster, 2020/12/11
- [PATCH 13/20] qobject: Drop qstring_get_try_str(), Markus Armbruster, 2020/12/11
- [PATCH 16/20] migration: Replace migration's JSON writer by the general one, Markus Armbruster, 2020/12/11
- Re: [PATCH 00/20] Immutable QString, and also one JSON writer less, Paolo Bonzini, 2020/12/22