Re: [PATCH v7 0/5] migration: UFFD write-tracking migration/snapshots

[no-reply]

Patchew URL: 
20201217130413.363172-1-andrey.gruzdev@virtuozzo.com/">https://patchew.org/QEMU/20201217130413.363172-1-andrey.gruzdev@virtuozzo.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201217130413.363172-1-andrey.gruzdev@virtuozzo.com
Subject: [PATCH v7 0/5] migration: UFFD write-tracking migration/snapshots

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20201217130413.363172-1-andrey.gruzdev@virtuozzo.com -> 
patchew/20201217130413.363172-1-andrey.gruzdev@virtuozzo.com
 - [tag update]      patchew/cover.1608142916.git.alistair.francis@wdc.com -> 
patchew/cover.1608142916.git.alistair.francis@wdc.com
Switched to a new branch 'test'
9ee702f migration: introduce 'userfaultfd-wrlat.py' script
2977b12 migration: implementation of background snapshot thread
5e91517 migration: support UFFD write fault processing in ram_save_iterate()
39885b4 migration: introduce UFFD-WP low-level interface helpers
5af2e3b migration: introduce 'background-snapshot' migration capability

=== OUTPUT BEGIN ===
1/5 Checking commit 5af2e3b78ed0 (migration: introduce 'background-snapshot' 
migration capability)
WARNING: line over 80 characters
#115: FILE: migration/migration.c:1225:
+            error_setg(errp, "Background-snapshot is not supported by host 
kernel");

WARNING: Block comments use a leading /* on a separate line
#192: FILE: migration/ram.c:3791:
+/* ram_write_tracking_available: check if kernel supports required UFFD 
features

WARNING: Block comments use a leading /* on a separate line
#202: FILE: migration/ram.c:3801:
+/* ram_write_tracking_compatible: check if guest configuration is

total: 0 errors, 3 warnings, 207 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit 39885b4d0da1 (migration: introduce UFFD-WP low-level 
interface helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

WARNING: line over 80 characters
#265: FILE: util/userfaultfd.c:163:
+ * uffd_change_protection: protect/un-protect memory range for writes via 
UFFD-IO

WARNING: line over 80 characters
#324: FILE: util/userfaultfd.c:222:
+        error_report("uffd_copy_page() failed: dst_addr=%p src_addr=%p 
length=%" PRIu64

WARNING: line over 80 characters
#364: FILE: util/userfaultfd.c:262:
+ * uffd_wakeup: wake up threads waiting on page UFFD-managed page fault 
resolution

WARNING: line over 80 characters
#385: FILE: util/userfaultfd.c:283:
+        error_report("uffd_wakeup() failed: addr=%p length=%" PRIu64 " 
errno=%i",

total: 0 errors, 5 warnings, 406 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 5e91517382d9 (migration: support UFFD write fault 
processing in ram_save_iterate())
WARNING: line over 80 characters
#168: FILE: migration/ram.c:1839:
+        /* We don't want to override existing error from ram_save_host_page(). 
*/

WARNING: Block comments use a leading /* on a separate line
#202: FILE: migration/ram.c:1987:
+        /* caller have hold iothread lock or is in a bh, so there is

WARNING: line over 80 characters
#331: FILE: migration/ram.c:4009:
+    error_report("ram_write_tracking_start() failed: restoring initial memory 
state");

WARNING: line over 80 characters
#341: FILE: migration/ram.c:4019:
+        uffd_change_protection(rs->uffdio_fd, bs->host, bs->max_length, false, 
false);

WARNING: line over 80 characters
#370: FILE: migration/ram.c:4048:
+        uffd_change_protection(rs->uffdio_fd, bs->host, bs->max_length, false, 
false);

total: 0 errors, 5 warnings, 361 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 2977b123ecbd (migration: implementation of background 
snapshot thread)
WARNING: line over 80 characters
#156: FILE: migration/migration.c:3810:
+ * mechanism, which effectively results in that saved snapshot is the state of 
VM

total: 0 errors, 1 warnings, 330 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit 9ee702f9344f (migration: introduce 'userfaultfd-wrlat.py' 
script)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

ERROR: please use python3 interpreter
#18: FILE: scripts/userfaultfd-wrlat.py:1:
+#!/usr/bin/python

ERROR: trailing whitespace
#113: FILE: scripts/userfaultfd-wrlat.py:96:
+     * or pending signal we'll still get (at least for v5.8.0 kernel) $

ERROR: trailing whitespace
#116: FILE: scripts/userfaultfd-wrlat.py:99:
+     * keeping initial timestamp unchanged for the faulting thread.  $

WARNING: line over 80 characters
#144: FILE: scripts/userfaultfd-wrlat.py:127:
+b.attach_kretprobe(event="handle_userfault", 
fn_name="retprobe_handle_userfault")

total: 3 errors, 2 warnings, 148 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201217130413.363172-1-andrey.gruzdev@virtuozzo.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201217130413.363172-1-andrey.gruzdev@virtuozzo.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com