[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls
|
From: |
Laurent Vivier |
|
Subject: |
Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls |
|
Date: |
Thu, 17 Dec 2020 21:14:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
Le 17/12/2020 à 17:10, Philippe Mathieu-Daudé a écrit :
> On 12/17/20 11:40 AM, Laurent Vivier wrote:
>> Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit :
>>> o32 ABI syscalls start at offset 4000.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> linux-user/mips64/syscall_nr.h | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/linux-user/mips64/syscall_nr.h b/linux-user/mips64/syscall_nr.h
>>> index 672f2fa51cb..6579421fa63 100644
>>> --- a/linux-user/mips64/syscall_nr.h
>>> +++ b/linux-user/mips64/syscall_nr.h
>>> @@ -1,4 +1,7 @@
>>> -#ifdef TARGET_ABI_MIPSN32
>>> +#if defined(TARGET_ABI_MIPSO32)
>>> +#define TARGET_SYSCALL_OFFSET 4000
>>
>> The value of the offset is hardcoded in linux-user/mips/meson.build, so
>> either you remove
>> TARGET_SYSCALL_OFFSET here or you update meson.build to use it.
>
> I don't understand what this Meson rule does, as this
> doesn't work without this patch...
Yes, you're right, this is hardcoded in mips directory, not in mips64 directory.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>