qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 2/3] block: add bdrv_co_delete_file_noerr


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v6 2/3] block: add bdrv_co_delete_file_noerr
Date: Fri, 18 Dec 2020 09:05:38 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1

17.12.2020 20:09, Maxim Levitsky wrote:
This function wraps bdrv_co_delete_file for the common case of removing a file,
which was just created by format driver, on an error condition.

It hides the -ENOTSUPP error, and reports all other errors otherwise.

Use it in luks driver

Signed-off-by: Maxim Levitsky<mlevitsk@redhat.com>
Reviewed-by: Alberto Garcia<berto@igalia.com>

I still doubt that not reporting ENOTSUPP has a real benefit.. Still, it's 
preexisting.

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]