Re: [PATCH v3] tests/acceptance: Add a test with the Fedora 31 kernel and initrd

[Thomas Huth]

On 21/12/2020 14.44, Cornelia Huck wrote:
> On Mon, 21 Dec 2020 14:32:54 +0100
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> This initrd contains a virtio-net and a virtio-gpu kernel module,
>> so we can check that we can set a MAC address for the network device
>> and whether we can hot-plug and -unplug a virtio-crypto device.
>> But the most interesting part is maybe that we can also successfully
>> write some stuff into the emulated framebuffer of the virtio-gpu
>> device and make sure that we can read back that data from a screenshot.
>>
>> Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com> 
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  v3:
>>  - Remove unused "import re"
>>  - Use lscss to test for devnos
>>  - Improve tmpfile handling (thanks Wainer!)
>>
>>  tests/acceptance/machine_s390_ccw_virtio.py | 110 ++++++++++++++++++++
>>  1 file changed, 110 insertions(+)
> 
> (...)
> 
>> +        # Some tests to see whether the CLI options have been considered:
>> +        self.log.info("Test whether QEMU CLI options have been considered")
>> +        exec_command_and_wait_for_pattern(self, 'lspci',
>> +                             '0007:00:00.0 Class 0200: Device 1af4:1000')
>> +        exec_command_and_wait_for_pattern(self,
>> +                             'cat /sys/class/net/enP7p0s0/address',
>> +                             '02:ca:fe:fa:ce:12')
>> +        exec_command_and_wait_for_pattern(self, 'lscss', '0.1.9876')
>> +        self.wait_for_console_pattern('0.2.5432')
> 
> This looks a bit odd... maybe do 'lscss -d 0.1.9876' and 'lscss -d
> 0.2.5432' and wait for the respective devnos to be printed?
> 
> (I'm not entirely sure about the wait_for_console_pattern semantics
> here... can the 0.2.5432 line have been printed already before we start
> waiting, and would that be a problem? Might be better to play it safe.)

Fine for me. Could you fix it up when picking up the patch? Or do you want
me to send a v4 ?

 Thomas