Re: [PATCH v15 04/13] qapi: add filter-node-name to block-stream

[Max Reitz]

On 16.12.20 07:16, Vladimir Sementsov-Ogievskiy wrote:
> From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
>
> Provide the possibility to pass the 'filter-node-name' parameter to the
> block-stream job as it is done for the commit block job.
>
> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>    [vsementsov: comment indentation, s/Since: 5.2/Since: 6.0/]
> Reviewed-by: Max Reitz <mreitz@redhat.com>
> ---
>   qapi/block-core.json           | 6 ++++++
>   include/block/block_int.h      | 7 ++++++-
>   block/monitor/block-hmp-cmds.c | 4 ++--
>   block/stream.c                 | 4 +++-
>   blockdev.c                     | 4 +++-
>   5 files changed, 20 insertions(+), 5 deletions(-)

[...]

> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index 1eeafc118c..6f778e2517 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -1142,6 +1142,9 @@ int is_windows_drive(const char *filename);
>    *                  See @BlockJobCreateFlags
>    * @speed: The maximum speed, in bytes per second, or 0 for unlimited.
>    * @on_error: The action to take upon error.
> + * @filter_node_name: The node name that should be assigned to the filter
> + *                    driver that the commit job inserts into the graph above

Only now noticed s/commit/stream/

(I’ll fix it)

Max

> + *                    @bs. NULL means that a node name should be autogenerated.
>    * @errp: Error object.
>    *
>    * Start a streaming operation on @bs.  Clusters that are unallocated