[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode |
|
Date: |
Sun, 27 Dec 2020 15:16:07 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/25/20 12:23 AM, BALATON Zoltan wrote:
> We'll need a flag for implementing some device specific behaviour in
> via-ide but we already have a currently CMD646 specific field that can
> be repurposed for this and leave room for furhter flags if needed in
> the future. This patch changes the "secondary" field to "flags" and
> change CMD646 and its users accordingly and define a new flag for
> forcing legacy mode that will be used by via-ide for now.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ide/cmd646.c | 4 ++--
> hw/sparc64/sun4u.c | 2 +-
> include/hw/ide/pci.h | 7 ++++++-
> 3 files changed, 9 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>