Re: [PATCH 03/12] vt82c686: Remove unnecessary _DEVICE suffix from type macros

[BALATON Zoltan]

On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote:
> On 12/27/20 2:10 AM, BALATON Zoltan via wrote:
> > There's no reason to suffix everything with _DEVICE when the names are
> > already unique without it and shorter names are more readable.
> >
> > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > ---
> >  hw/isa/vt82c686.c | 48 +++++++++++++++++++++++------------------------
> >  1 file changed, 23 insertions(+), 25 deletions(-)
> >
> > diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> > index 2a0f85dea9..1be1169f83 100644
> > --- a/hw/isa/vt82c686.c
> > +++ b/hw/isa/vt82c686.c
> > @@ -49,8 +49,8 @@ struct VT82C686BState {
> >      SuperIOConfig superio_conf;
> >  };
> >
> > -#define TYPE_VT82C686B_DEVICE "VT82C686B"
> > -OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B_DEVICE)
> > +#define TYPE_VT82C686B "VT82C686B"
> > +OBJECT_DECLARE_SIMPLE_TYPE(VT82C686BState, VT82C686B)
>
> Can we name this one VT82C686B_ISA?

Yes, actually this is coming up in later patches adding VT8231 but I still 
need to think about that. Once I clean that up but maybe I can do the 
rename already here.

Regards,
BALATON Zoltan