[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v26 00/20] i386 cleanup PART 2
From: |
no-reply |
Subject: |
Re: [PATCH v26 00/20] i386 cleanup PART 2 |
Date: |
Mon, 1 Mar 2021 01:18:56 -0800 (PST) |
Patchew URL: 20210301085450.1732-1-cfontana@suse.de/">https://patchew.org/QEMU/20210301085450.1732-1-cfontana@suse.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210301085450.1732-1-cfontana@suse.de
Subject: [PATCH v26 00/20] i386 cleanup PART 2
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210301085450.1732-1-cfontana@suse.de ->
patchew/20210301085450.1732-1-cfontana@suse.de
Switched to a new branch 'test'
00a5877 i386: make cpu_load_efer sysemu-only
bc37797 target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu
2b17816 target/i386: gdbstub: introduce aux functions to read/write CS64 regs
3a208cf i386: split off sysemu part of cpu.c
2c7e080 i386: split seg_helper into user-only and sysemu parts
d83014b i386: split svm_helper into sysemu and stub-only user
b6d69a4 i386: separate fpu_helper sysemu-only parts
93cb687 i386: split misc helper user stubs and sysemu part
d8352df i386: move TCG bpt_helper into sysemu/
8fbb05f i386: split tcg excp_helper into sysemu and user parts
0a91873 i386: split smm helper (sysemu)
86ad6ce i386: split off sysemu-only functionality in tcg-cpu
ecd60a2 meson: add target_user_arch
eec9c82 accel-cpu: make cpu_realizefn return a bool
007716a target/i386: fix host_cpu_adjust_phys_bits error handling
48530bb accel: introduce new accessor functions
cedc6f6 cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
ffbf00d i386: split cpu accelerators from cpu.c, using AccelCPUClass
d8033c6 target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor
d516237 target/i386: Rename helper_fldt, helper_fstt
=== OUTPUT BEGIN ===
1/20 Checking commit d5162371be89 (target/i386: Rename helper_fldt, helper_fstt)
2/20 Checking commit d8033c640ed4 (target/i386: Split out do_fsave, do_frstor,
do_fxsave, do_fxrstor)
3/20 Checking commit ffbf00db2eb3 (i386: split cpu accelerators from cpu.c,
using AccelCPUClass)
WARNING: line over 80 characters
#1337: FILE: target/i386/tcg/tcg-cpu.c:125:
+ memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem,
0);
total: 0 errors, 1 warnings, 1256 lines checked
Patch 3/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/20 Checking commit cedc6f6e4c18 (cpu: call AccelCPUClass::cpu_realizefn in
cpu_exec_realizefn)
5/20 Checking commit 48530bbeb4c2 (accel: introduce new accessor functions)
6/20 Checking commit 007716a87edf (target/i386: fix host_cpu_adjust_phys_bits
error handling)
7/20 Checking commit eec9c82ab85c (accel-cpu: make cpu_realizefn return a bool)
8/20 Checking commit ecd60a2189f5 (meson: add target_user_arch)
9/20 Checking commit 86ad6ce0eb6a (i386: split off sysemu-only functionality in
tcg-cpu)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31:
new file mode 100644
WARNING: line over 80 characters
#116: FILE: target/i386/tcg/sysemu/tcg-cpu.c:72:
+ memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem,
0);
total: 0 errors, 2 warnings, 212 lines checked
Patch 9/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/20 Checking commit 0a9187311234 (i386: split smm helper (sysemu))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24:
target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++-----------------
total: 0 errors, 1 warnings, 84 lines checked
Patch 10/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/20 Checking commit 8fbb05f77818 (i386: split tcg excp_helper into sysemu and
user parts)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#599:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#756: FILE: target/i386/tcg/sysemu/excp_helper.c:153:
+ /* Bits 20-13 provide bits 39-32 of the address, bit 21 is
reserved.
WARNING: Block comments use a leading /* on a separate line
#830: FILE: target/i386/tcg/sysemu/excp_helper.c:227:
+/* return value:
WARNING: line over 80 characters
#931: FILE: target/i386/tcg/sysemu/excp_helper.c:328:
+ pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff)
<< 3)) &
WARNING: Block comments use a leading /* on a separate line
#1025: FILE: target/i386/tcg/sysemu/excp_helper.c:422:
+ /* Bits 20-13 provide bits 39-32 of the address, bit 21 is
reserved.
WARNING: Block comments use a leading /* on a separate line
#1120: FILE: target/i386/tcg/sysemu/excp_helper.c:517:
+ /* only set write access if already dirty... otherwise wait
WARNING: Block comments use * on subsequent lines
#1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+ /* only set write access if already dirty... otherwise wait
+ for dirty access */
WARNING: Block comments use a trailing */ on a separate line
#1121: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+ for dirty access */
WARNING: Block comments use a leading /* on a separate line
#1134: FILE: target/i386/tcg/sysemu/excp_helper.c:531:
+ /* Even if 4MB pages, we map only one 4KB page in the cache to
WARNING: Block comments use * on subsequent lines
#1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+ /* Even if 4MB pages, we map only one 4KB page in the cache to
+ avoid filling it too fast */
WARNING: Block comments use a trailing */ on a separate line
#1135: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+ avoid filling it too fast */
ERROR: braces {} are necessary for all arms of this statement
#1149: FILE: target/i386/tcg/sysemu/excp_helper.c:546:
+ if (is_user)
[...]
total: 1 errors, 11 warnings, 631 lines checked
Patch 11/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/20 Checking commit d8352df00ca5 (i386: move TCG bpt_helper into sysemu/)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#364:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#500: FILE: target/i386/tcg/sysemu/bpt_helper.c:132:
+ /* If nothing is changing except the global/local enable bits,
WARNING: Block comments use * on subsequent lines
#501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+ /* If nothing is changing except the global/local enable bits,
+ then we can make the change more efficient. */
WARNING: Block comments use a trailing */ on a separate line
#501: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+ then we can make the change more efficient. */
WARNING: Block comments use a leading /* on a separate line
#503: FILE: target/i386/tcg/sysemu/bpt_helper.c:135:
+ /* Fold the global and local enable bits together into the
WARNING: Block comments use * on subsequent lines
#504: FILE: target/i386/tcg/sysemu/bpt_helper.c:136:
+ /* Fold the global and local enable bits together into the
+ global fields, then xor to show which registers have
WARNING: Block comments use a trailing */ on a separate line
#505: FILE: target/i386/tcg/sysemu/bpt_helper.c:137:
+ changed collective enable state. */
total: 0 errors, 7 warnings, 628 lines checked
Patch 12/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/20 Checking commit 93cb687b7b8c (i386: split misc helper user stubs and
sysemu part)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#527:
new file mode 100644
ERROR: switch and case should be at the same indent
#820: FILE: target/i386/tcg/sysemu/misc_helper.c:289:
+ switch ((uint32_t)env->regs[R_ECX]) {
[...]
+ case MSR_IA32_UCODE_REV:
total: 1 errors, 1 warnings, 1012 lines checked
Patch 13/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/20 Checking commit b6d69a4d70a7 (i386: separate fpu_helper sysemu-only parts)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#108:
new file mode 100644
total: 0 errors, 1 warnings, 135 lines checked
Patch 14/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/20 Checking commit d83014bb1c38 (i386: split svm_helper into sysemu and
stub-only user)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
target/i386/tcg/{ => sysemu}/svm_helper.c | 62 +------------------------
total: 0 errors, 1 warnings, 169 lines checked
Patch 15/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/20 Checking commit 2c7e080c0171 (i386: split seg_helper into user-only and
sysemu parts)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#321:
new file mode 100644
ERROR: do not use C99 // comments
#348: FILE: target/i386/tcg/seg_helper.h:23:
+//#define DEBUG_PCALL
WARNING: Block comments use a leading /* on a separate line
#621: FILE: target/i386/tcg/user/seg_helper.c:73:
+ /* Since we emulate only user space, we cannot do more than
WARNING: Block comments use * on subsequent lines
#622: FILE: target/i386/tcg/user/seg_helper.c:74:
+ /* Since we emulate only user space, we cannot do more than
+ exiting the emulation with the suitable exception and error
WARNING: Block comments use a trailing */ on a separate line
#623: FILE: target/i386/tcg/user/seg_helper.c:75:
+ code. So update EIP for INT 0x80 and EXCP_SYSCALL. */
WARNING: Block comments use a leading /* on a separate line
#634: FILE: target/i386/tcg/user/seg_helper.c:86:
+ /* if user mode only, we simulate a fake exception
WARNING: Block comments use * on subsequent lines
#635: FILE: target/i386/tcg/user/seg_helper.c:87:
+ /* if user mode only, we simulate a fake exception
+ which will be handled outside the cpu execution
WARNING: Block comments use a trailing */ on a separate line
#636: FILE: target/i386/tcg/user/seg_helper.c:88:
+ loop */
total: 1 errors, 7 warnings, 595 lines checked
Patch 16/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/20 Checking commit 3a208cf87826 (i386: split off sysemu part of cpu.c)
Use of uninitialized value $acpi_testexpected in string eq at
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#52: FILE: target/i386/cpu-internal.h:30:
+ /* feature flags names are taken from "Intel Processor Identification and
WARNING: Block comments use a leading /* on a separate line
#135: FILE: target/i386/cpu-sysemu.c:37:
+/* Return a QDict containing keys for all properties that can be included
WARNING: Block comments use a leading /* on a separate line
#188: FILE: target/i386/cpu-sysemu.c:90:
+/* Convert CPU model data from X86CPU object to a property dictionary
WARNING: Block comments use a leading /* on a separate line
#202: FILE: target/i386/cpu-sysemu.c:104:
+/* Convert CPU model data from X86CPU object to a property dictionary
WARNING: Block comments use a leading /* on a separate line
#218: FILE: target/i386/cpu-sysemu.c:120:
+ /* "hotplugged" is the only property that is configurable
WARNING: Block comments use a leading /* on a separate line
#308: FILE: target/i386/cpu-sysemu.c:210:
+ /* As we don't return every single property, full expansion needs
total: 0 errors, 7 warnings, 901 lines checked
Patch 17/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/20 Checking commit 2b1781677162 (target/i386: gdbstub: introduce aux
functions to read/write CS64 regs)
WARNING: line over 80 characters
#62: FILE: target/i386/gdbstub.c:163:
+ return gdb_read_reg_cs64(env->hflags, mem_buf,
env->segs[R_FS].base);
WARNING: line over 80 characters
#68: FILE: target/i386/gdbstub.c:165:
+ return gdb_read_reg_cs64(env->hflags, mem_buf,
env->segs[R_GS].base);
WARNING: line over 80 characters
#156: FILE: target/i386/gdbstub.c:318:
+ return gdb_write_reg_cs64(env->hflags, mem_buf,
&env->segs[R_FS].base);
WARNING: line over 80 characters
#165: FILE: target/i386/gdbstub.c:320:
+ return gdb_write_reg_cs64(env->hflags, mem_buf,
&env->segs[R_GS].base);
total: 0 errors, 4 warnings, 221 lines checked
Patch 18/20 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/20 Checking commit bc377979cd9a (target/i386: gdbstub: only write
CR0/CR2/CR3/EFER for sysemu)
20/20 Checking commit 00a5877fc1a3 (i386: make cpu_load_efer sysemu-only)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210301085450.1732-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20210301085450.1732-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v26 12/20] i386: move TCG bpt_helper into sysemu/, (continued)
- [PATCH v26 12/20] i386: move TCG bpt_helper into sysemu/, Claudio Fontana, 2021/03/01
- [PATCH v26 13/20] i386: split misc helper user stubs and sysemu part, Claudio Fontana, 2021/03/01
- [PATCH v26 18/20] target/i386: gdbstub: introduce aux functions to read/write CS64 regs, Claudio Fontana, 2021/03/01
- [PATCH v26 16/20] i386: split seg_helper into user-only and sysemu parts, Claudio Fontana, 2021/03/01
- [PATCH v26 11/20] i386: split tcg excp_helper into sysemu and user parts, Claudio Fontana, 2021/03/01
- [PATCH v26 14/20] i386: separate fpu_helper sysemu-only parts, Claudio Fontana, 2021/03/01
- [PATCH v26 17/20] i386: split off sysemu part of cpu.c, Claudio Fontana, 2021/03/01
- [PATCH v26 19/20] target/i386: gdbstub: only write CR0/CR2/CR3/EFER for sysemu, Claudio Fontana, 2021/03/01
- [PATCH v26 20/20] i386: make cpu_load_efer sysemu-only, Claudio Fontana, 2021/03/01
- [PATCH v26 15/20] i386: split svm_helper into sysemu and stub-only user, Claudio Fontana, 2021/03/01
- Re: [PATCH v26 00/20] i386 cleanup PART 2,
no-reply <=
- Re: [PATCH v26 00/20] i386 cleanup PART 2, Claudio Fontana, 2021/03/08
- Re: [PATCH v26 00/20] i386 cleanup PART 2, Alex Bennée, 2021/03/08