[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] docs: vhost-user: clean up request/reply description
From: |
Alex Bennée |
Subject: |
Re: [PATCH 1/3] docs: vhost-user: clean up request/reply description |
Date: |
Mon, 01 Mar 2021 11:33:02 +0000 |
User-agent: |
mu4e 1.5.8; emacs 28.0.50 |
Paolo Bonzini <pbonzini@redhat.com> writes:
> It is not necessary to mention which side is sending/receiving
> each payload; it is more interesting to say which is the request
> and which is the reply. This also matches what vhost-user-gpu.rst
> already does.
>
> While at it, ensure that all messages list both the request and
> the reply payload.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
<snip>
>
> When the ``VHOST_USER_PROTOCOL_F_STATUS`` protocol feature has been
> successfully negotiated, this message is submitted by the master to
> @@ -1351,11 +1375,14 @@ Master message types
> Slave message types
> -------------------
>
> +For this type of message, the request is sent by the slave and the reply
> +is sent by the master.
> +
It may be worth pointing out this language will be changed in a follow
up patch in the commit.
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée