|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v2 19/31] qapi/qom: QAPIfy object-add |
Date: | Mon, 1 Mar 2021 13:03:15 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 01/03/21 12:54, Kevin Wolf wrote:
Please add a check in object_property_add_child that the id is well formed (using the id_wellformed function). This is pre-existing, but it becomes a regression for -object later in the series.Are the conditions for internally called object_property_add_child() actually the same as for IDs specified by the user? For example, I seem to remember some array-ish properties with [] in their name which aren't allowed by id_wellformed().
Yes, you are right.
The obvious place to affect only the external interfaces would be user_creatable_add_type().
Makes sense, thanks. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |