[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/25] hmp: replace "O" parser with keyval
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 08/25] hmp: replace "O" parser with keyval |
Date: |
Mon, 01 Mar 2021 14:35:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 01/03/21 11:14, Markus Armbruster wrote:
>> There is no reason to reject those IDs other than spoiling the fun we're
>> having with setting traps for our users.
>>
>> Since QOM is treating '/' specially in paths, and uses IDs as path
>> components, it should reject '/' in IDs. Same reasoning as for file
>> names.
>
> I agree; however I don't think it buys anything to do that in HMP rather
> than further down the call chain, because in the end there are other
> ways to get "anti-social" ids than HMP or the command line. I commented
> on Kevin's object-add series about this issue.
Further down is better provided further down actually does it :)
Anyway, please amend the commit message to describe user-visible
differences. Doesn't have to be perfectly exhaustive; glossing over the
more eccentric corner cases should be okay.