qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/10] target/hexagon: call idef-parser functions


From: Alessandro Di Federico
Subject: Re: [PATCH v2 09/10] target/hexagon: call idef-parser functions
Date: Mon, 1 Mar 2021 15:49:49 +0100

On Thu, 25 Feb 2021 19:47:04 -0800
Richard Henderson <richard.henderson@linaro.org> wrote:

> On 2/25/21 7:18 AM, Alessandro Di Federico wrote:
> > +            elif hex_common.is_new_val(regtype, regid, tag):
> > +                declared.append("%s%sN" % (regtype,regid))
> > +            else:
> > +                print("Bad register parse:",regtype,regid,toss,numregs)  
> 
> print, but nothing to force exit-with-failure, now or at a later
> date.  Just raise a python exception?

Yes, the whole error handling should be improved in the script.

Our goal was to get this patchset in and then do another pass to clean
up things later on. However, if you deem this is the proper time to
do it, we can go for it.

-- 
Alessandro Di Federico
rev.ng



reply via email to

[Prev in Thread] Current Thread [Next in Thread]