|
From: | Richard Henderson |
Subject: | Re: [RFC v2 07/24] target/arm: move physical address translation to new modules |
Date: | Mon, 1 Mar 2021 10:49:13 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/1/21 8:49 AM, Claudio Fontana wrote:
--- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1023,9 +1023,6 @@ typedef struct ARMVAParameters { bool using64k : 1; } ARMVAParameters;-ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va,- ARMMMUIdx mmu_idx, bool data); -
Moving aa64_va_parameters away from its struct return is not good. Either move them both or not at all.
The collection of stuff you've split out into get-phys-addr.h is pretty random. Let's just leave it all in internals.h for now. We can make a more reasoned decision vs all of the vma and regime related functions.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |