[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 0/2] Clarify error messages pertaining to 'node-name'
From: |
Connor Kuehl |
Subject: |
[PATCH 0/2] Clarify error messages pertaining to 'node-name' |
Date: |
Mon, 1 Mar 2021 17:36:05 -0600 |
Some error messages contain ambiguous representations of the 'node-name'
parameter. This can be particularly confusing when exchanging QMP
messages (C = client, S = server):
C: {"execute": "block_resize", "arguments": { "device": "my_file", "size":
26843545600 }}
S: {"error": {"class": "GenericError", "desc": "Cannot find device=my_file nor
node_name="}}
^^^^^^^^^
This error message suggests one could send a message with a key called
'node_name':
C: {"execute": "block_resize", "arguments": { "node_name": "my_file", "size":
26843545600 }}
^^^^^^^^^
but using the underscore is actually incorrect, the parameter should be
'node-name':
S: {"error": {"class": "GenericError", "desc": "Parameter 'node_name' is
unexpected"}}
This behavior was uncovered in bz1651437[1], but I ended up going down a
rabbit hole looking for other areas where this miscommunication might
occur and changing those accordingly as well.
[1] https://bugzilla.redhat.com/1651437
Connor Kuehl (2):
block: Clarify error messages pertaining to 'node-name'
blockdev: Clarify error messages pertaining to 'node-name'
block.c | 8 ++++----
blockdev.c | 13 +++++++------
tests/qemu-iotests/040 | 4 ++--
tests/qemu-iotests/249.out | 2 +-
4 files changed, 14 insertions(+), 13 deletions(-)
--
2.29.2
- [PATCH 0/2] Clarify error messages pertaining to 'node-name',
Connor Kuehl <=