Re: [RFC v2 10/24] target/arm: only perform TCG cpu and machine inits if tcg enabled

[Richard Henderson]

On 3/1/21 8:49 AM, Claudio Fontana wrote:
> @@ -1321,6 +1323,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error 
> **errp)
>           }
>       }
>   
> +#ifdef CONFIG_TCG
>       {
>           uint64_t scale;
>   
> @@ -1346,7 +1349,8 @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
>           cpu->gt_timer[GTIMER_HYPVIRT] = timer_new(QEMU_CLOCK_VIRTUAL, scale,
>                                                     arm_gt_hvtimer_cb, cpu);
>       }
> -#endif
> +#endif /* CONFIG_TCG */

You can use tcg_enabled here.

> -        }
>   
>   #ifndef CONFIG_USER_ONLY
> -        cpu->pmu_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, arm_pmu_timer_cb,
> -                cpu);
> +            cpu->pmu_timer = timer_new_ns(QEMU_CLOCK_VIRTUAL, arm_pmu_timer_cb,
> +                                          cpu);

Incorrect indentation change.
Otherwise, LGTM.


r~