Re: [RFC v2 12/24] target/arm: move cpsr_read, cpsr_write to cpu_common

[Claudio Fontana]

On 3/2/21 5:02 AM, Richard Henderson wrote:
> On 3/1/21 8:49 AM, Claudio Fontana wrote:
>> we need as a result to move switch_mode too,
>> so we put an implementation into cpu_user and cpu_sysemu.
>>
>> Signed-off-by: Claudio Fontana<cfontana@suse.de>
>> ---
>>   target/arm/cpu.h        |   2 +
>>   target/arm/cpu-common.c | 182 +++++++++++++++++++++++++++++++++
>>   target/arm/cpu-sysemu.c |  29 ++++++
>>   target/arm/cpu-user.c   |  24 +++++
>>   target/arm/tcg/helper.c | 221 ----------------------------------------
>>   target/arm/meson.build  |   3 +
>>   6 files changed, 240 insertions(+), 221 deletions(-)
>>   create mode 100644 target/arm/cpu-user.c
> 
> Some commentary about what cpu-common.c is meant to be would be helpful.  So 
> far it looks like helper.c under a different name.
> 
> r~
> 

In the intention,

cpu-common.c, cpu-sysemu.c, cpu-user.c

cpu-common.c: cpu class definitions and functions common between sysemu and user
cpu-sysemu.c: sysemu-only cpu class definitions and functions
cpu-user.c: user-only

I agree that things need improving to get there, 
will take a good look,

thanks,

C