[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] meson: add tests option
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH] meson: add tests option |
Date: |
Tue, 2 Mar 2021 12:08:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 02/03/21 11:22, Thomas Huth wrote:
On 26/02/2021 23.07, Romain Naour wrote:
tests/fp/fp-bench.c use fenv.h that is not always provided
by the libc (uClibc).
For such problem it might be better to check for the availability of
the header and then to only disable the single test that depends on it
if the header is not available.
Anyway, a switch to disable the tests completely could still be handy in
some cases, so FWIW:
Acked-by: Thomas Huth <thuth@redhat.com>
I disagree, without a use case the right thing to do is to check for
fenv.h. It's as easy as this:
diff --git a/tests/meson.build b/tests/meson.build
index 0c939f89f7..3b9b2f0483 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -281,7 +281,7 @@ test('decodetree', sh,
workdir: meson.current_source_dir() / 'decode',
suite: 'decodetree')
-if 'CONFIG_TCG' in config_all
+if 'CONFIG_TCG' in config_all and cc.has_header('fenv.h')
subdir('fp')
endif
Thanks,
Paolo