[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 21/24] target/arm: cpu64: wrap TCG-only parts of aarch64_cpu
|
From: |
Claudio Fontana |
|
Subject: |
Re: [RFC v2 21/24] target/arm: cpu64: wrap TCG-only parts of aarch64_cpu_dump_state |
|
Date: |
Tue, 2 Mar 2021 19:01:51 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 3/2/21 5:56 PM, Richard Henderson wrote:
> On 3/1/21 8:49 AM, Claudio Fontana wrote:
>> - if (cpu_isar_feature(aa64_sve, cpu) && sve_exception_el(env, el) == 0) {
>> + if (tcg_enabled() &&
>> + cpu_isar_feature(aa64_sve, cpu) && sve_exception_el(env, el) == 0) {
>
> There's nothing tcg-only about this -- kvm supports sve.
>
> r~
>
Indeed, on my box I am using probably just the cpu_isar_feature check fails.
This is basically an open question: do we need an sve_exception_el helper stub
that always returns 0?
Thanks,
Claudio