[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 26/42] esp: rename get_cmd_cb() to esp_select()
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 26/42] esp: rename get_cmd_cb() to esp_select() |
Date: |
Tue, 2 Mar 2021 22:51:30 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
Le 09/02/2021 à 20:30, Mark Cave-Ayland a écrit :
> This better describes the purpose of the function.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/scsi/esp.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
> index 921f79ae89..6736e7142c 100644
> --- a/hw/scsi/esp.c
> +++ b/hw/scsi/esp.c
> @@ -199,7 +199,7 @@ static void esp_pdma_write(ESPState *s, uint8_t val)
> esp_set_tc(s, dmalen);
> }
>
> -static int get_cmd_cb(ESPState *s)
> +static int esp_select(ESPState *s)
> {
> int target;
>
> @@ -256,7 +256,7 @@ static uint32_t get_cmd(ESPState *s)
> }
> trace_esp_get_cmd(dmalen, target);
>
> - if (get_cmd_cb(s) < 0) {
> + if (esp_select(s) < 0) {
> return 0;
> }
> return dmalen;
> @@ -299,7 +299,7 @@ static void do_cmd(ESPState *s)
>
> static void satn_pdma_cb(ESPState *s)
> {
> - if (get_cmd_cb(s) < 0) {
> + if (esp_select(s) < 0) {
> return;
> }
> s->do_cmd = 0;
> @@ -325,7 +325,7 @@ static void handle_satn(ESPState *s)
>
> static void s_without_satn_pdma_cb(ESPState *s)
> {
> - if (get_cmd_cb(s) < 0) {
> + if (esp_select(s) < 0) {
> return;
> }
> s->do_cmd = 0;
> @@ -351,7 +351,7 @@ static void handle_s_without_atn(ESPState *s)
>
> static void satn_stop_pdma_cb(ESPState *s)
> {
> - if (get_cmd_cb(s) < 0) {
> + if (esp_select(s) < 0) {
> return;
> }
> s->do_cmd = 0;
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 26/42] esp: rename get_cmd_cb() to esp_select(),
Laurent Vivier <=