[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] chardev: add nodelay option
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2] chardev: add nodelay option |
Date: |
Wed, 03 Mar 2021 14:51:32 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 03/03/21 14:24, Markus Armbruster wrote:
>> $ qemu-system-x86_64 -chardev socket,id=chr0,path=sock,nodelay=on
>> qemu-system-x86_64: -chardev socket,id=chr0,path=sock,nodelay=on: Invalid
>> parameter 'nodelay'
>>
>> You forgot to update qemu_chardev_opts:
>>
>> diff --git a/chardev/char.c b/chardev/char.c
>> index 288efebd12..e6128c046f 100644
>> --- a/chardev/char.c
>> +++ b/chardev/char.c
>> @@ -864,6 +864,9 @@ QemuOptsList qemu_chardev_opts = {
>> },{
>> .name = "server",
>> .type = QEMU_OPT_BOOL,
>> + },{
>> + .name = "nodelay",
>> + .type = QEMU_OPT_BOOL,
>> },{
>> .name = "delay",
>> .type = QEMU_OPT_BOOL,
>
> Well, I forgot to commit it. But the outcome is the same. Thanks. :(
Happens to the best of us :)
I'm glad I didn't accuse you of forgetting to test!