Re: [PATCH v2 13/25] tests/docker: expand centos7 package list

[Thomas Huth]

On 14/01/2021 14.02, Daniel P. Berrangé wrote:
> This is the fully expanded list of build pre-requisites QEMU can
> conceivably use in any scenario.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   tests/docker/dockerfiles/centos7.docker | 58 +++++++++++++++++++++++++
>   1 file changed, 58 insertions(+)
>
> diff --git a/tests/docker/dockerfiles/centos7.docker 
> b/tests/docker/dockerfiles/centos7.docker
> index 1eb3455144..d2daaae25b 100644
> --- a/tests/docker/dockerfiles/centos7.docker
> +++ b/tests/docker/dockerfiles/centos7.docker
> @@ -6,37 +6,95 @@ RUN yum -y update
>   # Please keep this list sorted alphabetically
>   ENV PACKAGES \
>       SDL2-devel \
> +    alsa-lib-devel \
> +    bc \

Why is bc suddenly required now?

> +    brlapi-devel \
>       bzip2 \
>       bzip2-devel \
> +    ca-certificates \
> +    capstone-devel \

capstone in Centos 7 is definitely too old - we need >= 4.0 now, and Centos 
7 still uses 3.0 if I've got that right.

>       ccache \
> +    clang \
> +    cyrus-sasl-devel \
> +    daxctl-devel \
>       dbus \
> +    device-mapper-multipath-devel \
> +    diffutils \
> +    findutils \
>       gcc \
>       gcc-c++ \
> +    genisoimage \
>       gettext \
>       git \
>       glib2-devel \
> +    glibc-common \
> +    glusterfs-api-devel \
>       gnutls-devel \
> +    gtk3-devel \
> +    hostname \
>       libaio-devel \
> +    libasan \
> +    libattr-devel \
>       libcacard-devel \
> +    libcap-ng-devel \
> +    libcurl-devel \
> +    libdrm-devel \
>       libepoxy-devel \
>       libfdt-devel \
>       libgcrypt-devel \
> +    libiscsi-devel \
> +    libjpeg-devel \
> +    libnfs-devel \
> +    libpmem-devel \
> +    libpng-devel \
> +    librbd1-devel \
> +    libseccomp-devel \
> +    libssh-devel \
> +    libtasn1-devel \
> +    libudev-devel \
> +    libusbx-devel \
> +    libxml2-devel \
>       libzstd-devel \
>       lzo-devel \
>       make \
>       mesa-libgbm-devel \
> +    ncurses-devel \
>       nettle-devel \
>       ninja-build \
> +    nmap-ncat \
> +    numactl-devel \
> +    openssh-clients \
> +    pam-devel \
> +    perl \
>       perl-Test-Harness \
>       pixman-devel \
> +    pkgconfig \
> +    pulseaudio-libs-devel \
>       python3 \
> +    python3-PyYAML \
> +    python3-numpy \
> +    python3-pillow \
> +    python3-pip \
> +    python3-setuptools \
> +    python3-sphinx \
> +    python3-virtualenv \
> +    python3-wheel \
>       rdma-core-devel \
> +    rpm \

Why rpm ?

> +    sed \

Do we really need to specify sed separately?

>       snappy-devel \
>       spice-protocol \
>       spice-server-devel \
> +    systemd-devel \
> +    systemtap-sdt-devel \
>       tar \
> +    texinfo \
> +    usbredir-devel \
> +    vim-minimal \

vim? Why that?

>       vte291-devel \
> +    which \
>       xen-devel \
> +    xfsprogs-devel \
>       zlib-devel
>   RUN yum install -y $PACKAGES
>   RUN rpm -q $PACKAGES | sort > /packages.txt

 Thomas