[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of i
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse |
Date: |
Wed, 3 Mar 2021 18:11:41 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Wed, Mar 03, 2021 at 10:06:50AM -0800, Doug Evans wrote:
> On Sun, Feb 28, 2021 at 1:40 PM Samuel Thibault <samuel.thibault@gnu.org>
> wrote:
>
> > [...]
> >
> > > + Examples:
> > > + hostfwd_add net0 tcp:127.0.0.1:10022-:22
> > > + hostfwd_add net0 tcp:[::1]:10022-[fe80::1:2:3:4]:22
> >
> > Yep, that looks good to me.
> >
> >
>
> Daniel, you wanted me to use inet_parse().
> Is the above syntax ok with you?
> You must have had some expectation that at least some of
> the various flags that inet_parse() recognizes would be needed here.
It feels like the ,ipv4=on|off,ipv6=on|off flags are relevant here,
especially in the empty address case. eg
tcp::10022 - attempt to listen on both ipv4 + ipv6
tcp::10022,ipv4=off - listen on default address, but only for ipv6
tcp::10022,ipv6=off - listen on default address, but only for ipv4
Basically this ends up bringing the hostfwd stuff into alignment with
the way other backends deal with this
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Markus Armbruster, 2021/03/01
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/01
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/01
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/03
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse,
Daniel P . Berrangé <=
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/05
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Samuel Thibault, 2021/03/05
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/05
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Samuel Thibault, 2021/03/06
- Re: [PATCH v4 2/4] util/qemu-sockets.c: Split host:port parsing out of inet_parse, Doug Evans, 2021/03/14