[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 31/42] esp: implement FIFO flush command
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 31/42] esp: implement FIFO flush command |
Date: |
Wed, 3 Mar 2021 20:32:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
Le 09/02/2021 à 20:30, Mark Cave-Ayland a écrit :
> At this point it is now possible to properly implement the FIFO flush command
> without causing guest errors.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/scsi/esp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
> index 1d56c99527..0994673ff8 100644
> --- a/hw/scsi/esp.c
> +++ b/hw/scsi/esp.c
> @@ -770,6 +770,8 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64_t
> val)
> case CMD_FLUSH:
> trace_esp_mem_writeb_cmd_flush(val);
> /*s->ti_size = 0;*/
> + s->ti_wptr = 0;
> + s->ti_rptr = 0;
> s->rregs[ESP_RINTR] = INTR_FC;
> s->rregs[ESP_RSEQ] = 0;
> s->rregs[ESP_RFLAGS] = 0;
>
Why don't you set aso ti_size to 0?
Anyway:
Reviwed-by: Laurent Vivier <laurent@vivier.eu>
Thanks,
Laurent
- Re: [PATCH v2 31/42] esp: implement FIFO flush command,
Laurent Vivier <=