[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qemu-option: do not suggest using the delay option
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH] qemu-option: do not suggest using the delay option |
Date: |
Thu, 4 Mar 2021 10:54:47 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Thu, Mar 04, 2021 at 11:28:27AM +0100, Paolo Bonzini wrote:
> The "delay" option was a hack that was introduced to allow writing "nodelay".
> We are adding a "nodelay" option to be used as "nodelay=on", so recommend it
> instead of "delay".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> This is quite ugly, so I am posting it as RFC in case others
> have better idea. Nevertheless, a proper deprecation of "delay"
> cannot be done if QEMU starts suggesting it, and since it's the
> only case I opted for this very much ad-hoc patch.
It is ugly, but this is a rare enough edge case that I think we can live
with it.
> ---
> docs/system/deprecated.rst | 6 ++++++
> util/qemu-option.c | 7 ++++++-
> 2 files changed, 12 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|