[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Autoconnect jack ports by default
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2] Autoconnect jack ports by default |
Date: |
Thu, 4 Mar 2021 13:53:11 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Thu, Mar 04, 2021 at 02:12:52PM +0100, Gerd Hoffmann wrote:
> > I'd suggest a "auto-connect-ports" boolean option, which defaults to
> > enabled.
> >
> > - auto-connect-ports == true, connect-ports= <unset>
> >
> > => use the proposed default regex for connect ports
> >
> > - auto-connect-ports == true, connect-ports = regex
> >
> > => use the connect-ports regex
> >
> > - auto-connect-ports == false, connect-ports= <unset>
> >
> > => don't auto connect at all
> >
> > - auto-connect-ports == false, connect-ports=regex
> >
> > => logically inconsistent config, report an error
>
> Well, we need two options then, and have one inconsistent variant.
> Can't we just get along with connect-ports alone, by using the empty
> string for "do not auto connect" ?
Historically we've been unable to distinguish between the <unset> and
<set-to-empty-string> scenarios when parsing CLI args. Maybe that
isn't a problem for -audiodev since we're not using QemuOpts for
parsing ?
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|