[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] block/file-posix: Optimize for macOS
From: |
no-reply |
Subject: |
Re: [PATCH v2] block/file-posix: Optimize for macOS |
Date: |
Fri, 5 Mar 2021 04:21:45 -0800 (PST) |
Patchew URL:
20210305121748.65173-1-akihiko.odaki@gmail.com/">https://patchew.org/QEMU/20210305121748.65173-1-akihiko.odaki@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210305121748.65173-1-akihiko.odaki@gmail.com
Subject: [PATCH v2] block/file-posix: Optimize for macOS
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210305121748.65173-1-akihiko.odaki@gmail.com ->
patchew/20210305121748.65173-1-akihiko.odaki@gmail.com
Switched to a new branch 'test'
16b639a block/file-posix: Optimize for macOS
=== OUTPUT BEGIN ===
WARNING: architecture specific defines should be avoided
#95: FILE: block/file-posix.c:2133:
+#if defined(__APPLE__) && (__MACH__)
ERROR: suspect code indent for conditional statements (8, 11)
#168: FILE: hw/block/block.c:73:
+ if (!backend_ret && blocksizes.phys) {
conf->physical_block_size = blocksizes.phys;
total: 1 errors, 1 warnings, 145 lines checked
Commit 16b639a81c45 (block/file-posix: Optimize for macOS) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210305121748.65173-1-akihiko.odaki@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210305121748.65173-1-akihiko.odaki@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v2] block/file-posix: Optimize for macOS, Akihiko Odaki, 2021/03/05
- Re: [PATCH v2] block/file-posix: Optimize for macOS,
no-reply <=
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Stefan Hajnoczi, 2021/03/08
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Akihiko Odaki, 2021/03/08
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Akihiko Odaki, 2021/03/08
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Kevin Wolf, 2021/03/09
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Daniel P . Berrangé, 2021/03/09
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Kevin Wolf, 2021/03/09
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Akihiko Odaki, 2021/03/09
- Re: [PATCH v2] block/file-posix: Optimize for macOS, Stefan Hajnoczi, 2021/03/10