[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration |
Date: |
Mon, 8 Mar 2021 11:23:28 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Fri, Mar 05, 2021 at 09:06:45AM +0100, Markus Armbruster wrote:
> Markus Armbruster <armbru@redhat.com> writes:
>
> > Daniel P. Berrangé <berrange@redhat.com> writes:
> >
> >> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> >>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
> >>> configuring floppies with -global isa-fdc" (v5.1.0).
> >>>
> >>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> [...]
> > Sadly, the commit's update of docs/system/deprecated.rst neglects to
> > cover this use. Looks the series overtaxed my capacity to juggle
> > details; my apologies.
> [...]
>
> I'm talking about commit 4a27a638e7 here.
>
> The deprecated.rst text only covers setting floppy controller properties
> with -global. It neglects to cover setting them with -device. For
> onboard controllers, -global is the only way to set them.
>
> I append a fixup.
>
> We can put it before this patch. This patch then moves the fixed up
> text to removed-features.rst.
>
> Or we squash it into this patch, i.e. this patch deletes the flawed text
> from deprecated.rst and adds the fixed up text to removed-features.rst.
>
> Got a preference?
I'm fine with either option. It isn't unusual to tweak the text when
moving it to the removed-features.rst file, as we'll be talking about
the past rather than future.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common(), (continued)
- [PATCH v2 2/3] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common(), Markus Armbruster, 2021/03/04
- [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Peter Krempa, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Daniel P . Berrangé, 2021/03/04
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/05
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration, Markus Armbruster, 2021/03/05
- Re: [PATCH v2 1/3] fdc: Drop deprecated floppy configuration,
Daniel P . Berrangé <=
[PATCH v2 3/3] blockdev: Drop deprecated bogus -drive interface type, Markus Armbruster, 2021/03/04