[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 33/38] hw/block/nvme: fix allocated namespace list to 256
From: |
Klaus Jensen |
Subject: |
[PULL 33/38] hw/block/nvme: fix allocated namespace list to 256 |
Date: |
Mon, 8 Mar 2021 13:23:08 +0100 |
From: Minwoo Im <minwoo.im.dev@gmail.com>
Expand allocated namespace list (subsys->namespaces) to have 256 entries
which is a value lager than at least NVME_MAX_NAMESPACES which is for
attached namespace list in a controller.
Allocated namespace list should at least larger than attached namespace
list.
n->num_namespaces = NVME_MAX_NAMESPACES;
The above line will set the NN field by id->nn so that the subsystem
should also prepare at least this number of namespace list entries.
Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Tested-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/block/nvme-subsys.h | 2 +-
hw/block/nvme.h | 6 ++++++
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/block/nvme-subsys.h b/hw/block/nvme-subsys.h
index 574774390c4c..8a0732b22316 100644
--- a/hw/block/nvme-subsys.h
+++ b/hw/block/nvme-subsys.h
@@ -14,7 +14,7 @@
OBJECT_CHECK(NvmeSubsystem, (obj), TYPE_NVME_SUBSYS)
#define NVME_SUBSYS_MAX_CTRLS 32
-#define NVME_SUBSYS_MAX_NAMESPACES 32
+#define NVME_SUBSYS_MAX_NAMESPACES 256
typedef struct NvmeCtrl NvmeCtrl;
typedef struct NvmeNamespace NvmeNamespace;
diff --git a/hw/block/nvme.h b/hw/block/nvme.h
index cd8d40634411..85a7b5a14f4e 100644
--- a/hw/block/nvme.h
+++ b/hw/block/nvme.h
@@ -10,6 +10,12 @@
#define NVME_DEFAULT_ZONE_SIZE (128 * MiB)
#define NVME_DEFAULT_MAX_ZA_SIZE (128 * KiB)
+/*
+ * Subsystem namespace list for allocated namespaces should be larger than
+ * attached namespace list in a controller.
+ */
+QEMU_BUILD_BUG_ON(NVME_MAX_NAMESPACES > NVME_SUBSYS_MAX_NAMESPACES);
+
typedef struct NvmeParams {
char *serial;
uint32_t num_queues; /* deprecated since 5.1 */
--
2.30.1
- [PULL 30/38] hw/block/nvme: refactor nvme_dma, (continued)
- [PULL 30/38] hw/block/nvme: refactor nvme_dma, Klaus Jensen, 2021/03/08
- [PULL 21/38] hw/block/nvme: add identify trace event, Klaus Jensen, 2021/03/08
- [PULL 24/38] hw/block/nvme: report non-mdts command size limit for dsm, Klaus Jensen, 2021/03/08
- [PULL 25/38] hw/block/nvme: remove redundant len member in compare context, Klaus Jensen, 2021/03/08
- [PULL 22/38] hw/block/nvme: fix potential compilation error, Klaus Jensen, 2021/03/08
- [PULL 26/38] hw/block/nvme: remove block accounting for write zeroes, Klaus Jensen, 2021/03/08
- [PULL 23/38] hw/block/nvme: add trace event for zone read check, Klaus Jensen, 2021/03/08
- [PULL 31/38] hw/block/nvme: support namespace detach, Klaus Jensen, 2021/03/08
- [PULL 32/38] hw/block/nvme: fix namespaces array to 1-based, Klaus Jensen, 2021/03/08
- [PULL 27/38] hw/block/nvme: fix strerror printing, Klaus Jensen, 2021/03/08
- [PULL 33/38] hw/block/nvme: fix allocated namespace list to 256,
Klaus Jensen <=
- [PULL 35/38] hw/block/nvme: refactor nvme_select_ns_iocs, Klaus Jensen, 2021/03/08
- [PULL 34/38] hw/block/nvme: support allocated namespace type, Klaus Jensen, 2021/03/08
- [PULL 37/38] hw/block/nvme: support changed namespace asynchronous event, Klaus Jensen, 2021/03/08
- [PULL 38/38] hw/block/nvme: support Identify NS Attached Controller List, Klaus Jensen, 2021/03/08
- [PULL 36/38] hw/block/nvme: support namespace attachment command, Klaus Jensen, 2021/03/08