[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPIN
From: |
Alistair Francis |
Subject: |
Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO |
Date: |
Mon, 8 Mar 2021 08:36:44 -0500 |
On Mon, Mar 8, 2021 at 5:10 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Sat, 6 Mar 2021 at 16:54, Keith Packard <keithp@keithp.com> wrote:
> >
> > Peter Maydell <peter.maydell@linaro.org> writes:
> > > Part of why I asked is that the current RISCV implementation
> > > is just looking at sizeof(target_ulong); but the qemu-system-riscv64
> > > executable AIUI now supports emulating both "this is a 64 bit
> > > guest CPU" and "this is a 32 bit host CPU", and so looking at
> > > a QEMU-compile-time value like "sizeof(target_ulong)" will
> > > produce the wrong answer for 32-bit CPUs emulated in
> > > the qemu-system-riscv64 binary. My guess is maybe
> > > it should be looking at the result of riscv_cpu_is_32bit() instead.
> >
> > Wow. I read through the code and couldn't find anything that looked like
> > it supported that, sounds like I must have missed something?
riscv_cpu_is_32bit() is somewhat new, so it might not have been there
when you wrote the patches.
>
> I thought Alistair had done that work (which brings riscv into
> line with the other 32/64 bit QEMU targets, which all support
> the 32-bit CPU types in the 64-bit-capable executable). But maybe
> it hasn't landed in master yet?
I have started on the effort, but I have not finished yet. Adding
riscv_cpu_is_32bit() was the first step there and I have some more
patches locally but I don't have anything working yet.
Alistair
>
> thanks
> -- PMM
- [PATCH v1 2/3] semihosting: Move hw/semihosting/ -> semihosting/, (continued)
- [PATCH v1 2/3] semihosting: Move hw/semihosting/ -> semihosting/, Alex Bennée, 2021/03/05
- [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Alex Bennée, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Peter Maydell, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Keith Packard, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Peter Maydell, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Keith Packard, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Richard Henderson, 2021/03/05
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Peter Maydell, 2021/03/06
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Keith Packard, 2021/03/06
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Peter Maydell, 2021/03/08
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO,
Alistair Francis <=
- Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Keith Packard, 2021/03/08
Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO, Keith Packard, 2021/03/05
[PATCH v1 1/3] semihosting: Move include/hw/semihosting/ -> include/semihosting/, Alex Bennée, 2021/03/05