[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ui/gtk: Remove NULL checks in gd_switch
From: |
Peter Maydell |
Subject: |
Re: [PATCH] ui/gtk: Remove NULL checks in gd_switch |
Date: |
Mon, 8 Mar 2021 14:09:46 +0000 |
On Mon, 8 Mar 2021 at 14:07, Akihiko Odaki <akihiko.odaki@gmail.com> wrote:
>
> c821a58ee7 ("ui/console: Pass placeholder surface to display")
> eliminated the possibility that NULL is passed as surface to
> dpy_gfx_switch and removed some NULL checks from gd_switch, but the
> removal was not thoroughly. Remaining NULL checks were confusing for
> Coverity and probably also for humans. This change removes those NULL
> checks.
>
> Reported-by: Coverity (CID 1448421)
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM