[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/5] m68k: add Virtual M68k Machine
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v6 5/5] m68k: add Virtual M68k Machine |
Date: |
Mon, 8 Mar 2021 23:17:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/8/21 10:25 PM, Laurent Vivier wrote:
> The machine is based on Goldfish interfaces defined by Google
> for Android simulator. It uses Goldfish-rtc (timer and RTC),
> Goldfish-pic (PIC) and Goldfish-tty (for serial port and early tty).
>
> The machine is created with 128 virtio-mmio bus, and they can
> be used to use serial console, GPU, disk, NIC, HID, ...
>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> default-configs/devices/m68k-softmmu.mak | 1 +
> .../standard-headers/asm-m68k/bootinfo-virt.h | 18 +
> hw/m68k/virt.c | 313 ++++++++++++++++++
> MAINTAINERS | 13 +
> hw/m68k/Kconfig | 10 +
> hw/m68k/meson.build | 1 +
> 6 files changed, 356 insertions(+)
> create mode 100644 include/standard-headers/asm-m68k/bootinfo-virt.h
> create mode 100644 hw/m68k/virt.c
> +config M68K_VIRT
> + bool
> + select M68K_IRQC
> + select VIRT_CTRL
> + select GOLDFISH_PIC
> + select GOLDFISH_TTY
> + select GOLDFISH_RTC
> + select VIRTIO
You don't seem to use VIRTIO directly but via VIRTIO_MMIO
which already selects VIRTIO, so you could remove this
line (keeping the next one). Just nitpicking...
> + select VIRTIO_MMIO
- [PATCH v6 0/5] m68k: add Virtual M68k Machine, Laurent Vivier, 2021/03/08
- [PATCH v6 1/5] char: add goldfish-tty, Laurent Vivier, 2021/03/08
- [PATCH v6 2/5] intc: add goldfish-pic, Laurent Vivier, 2021/03/08
- [PATCH v6 5/5] m68k: add Virtual M68k Machine, Laurent Vivier, 2021/03/08
- Re: [PATCH v6 5/5] m68k: add Virtual M68k Machine,
Philippe Mathieu-Daudé <=
- [PATCH v6 3/5] m68k: add an interrupt controller, Laurent Vivier, 2021/03/08
- [PATCH v6 4/5] m68k: add a system controller, Laurent Vivier, 2021/03/08
- Re: [PATCH v6 0/5] m68k: add Virtual M68k Machine, Philippe Mathieu-Daudé, 2021/03/08