[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/30] qapi/qom: Add ObjectOptions for tls-*, deprecate 'l
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 10/30] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded' |
Date: |
Tue, 9 Mar 2021 09:23:36 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Mon, Mar 08, 2021 at 05:54:20PM +0100, Kevin Wolf wrote:
> This adds a QAPI schema for the properties of the tls-* objects.
>
> The 'loaded' property doesn't seem to make sense as an external
> interface: It is automatically set to true in ucc->complete, and
> explicitly setting it to true earlier just means that additional options
> will be silently ignored.
>
> In other words, the 'loaded' property is useless. Mark it as deprecated
> in the schema from the start.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> Acked-by: Peter Krempa <pkrempa@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> qapi/crypto.json | 98 ++++++++++++++++++++++++++++++++++++++++++++++++
> qapi/qom.json | 12 +++++-
> 2 files changed, 108 insertions(+), 2 deletions(-)
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 03/30] qapi/qom: Add ObjectOptions for authz-*, (continued)
- [PATCH v3 04/30] qapi/qom: Add ObjectOptions for cryptodev-*, Kevin Wolf, 2021/03/08
- [PATCH v3 05/30] qapi/qom: Add ObjectOptions for dbus-vmstate, Kevin Wolf, 2021/03/08
- [PATCH v3 06/30] qapi/qom: Add ObjectOptions for memory-backend-*, Kevin Wolf, 2021/03/08
- [PATCH v3 07/30] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened', Kevin Wolf, 2021/03/08
- [PATCH v3 09/30] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded', Kevin Wolf, 2021/03/08
- [PATCH v3 10/30] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded', Kevin Wolf, 2021/03/08
- Re: [PATCH v3 10/30] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded',
Daniel P . Berrangé <=
- [PATCH v3 11/30] qapi/qom: Add ObjectOptions for can-*, Kevin Wolf, 2021/03/08
- [PATCH v3 12/30] qapi/qom: Add ObjectOptions for colo-compare, Kevin Wolf, 2021/03/08
- [PATCH v3 14/30] qapi/qom: Add ObjectOptions for pr-manager-helper, Kevin Wolf, 2021/03/08
- [PATCH v3 13/30] qapi/qom: Add ObjectOptions for filter-*, Kevin Wolf, 2021/03/08
- [PATCH v3 17/30] qapi/qom: Add ObjectOptions for x-remote-object, Kevin Wolf, 2021/03/08
- [PATCH v3 18/30] qapi/qom: QAPIfy object-add, Kevin Wolf, 2021/03/08
- [PATCH v3 19/30] qom: Make "object" QemuOptsList optional, Kevin Wolf, 2021/03/08
- [PATCH v3 20/30] qemu-storage-daemon: Implement --object with qmp_object_add(), Kevin Wolf, 2021/03/08
- [PATCH v3 08/30] qapi/qom: Add ObjectOptions for throttle-group, Kevin Wolf, 2021/03/08
- [PATCH v3 21/30] qom: Remove user_creatable_add_dict(), Kevin Wolf, 2021/03/08