[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/4] slirp: feature detection for smbd
From: |
Joelle van Dyne |
Subject: |
Re: [PATCH v2 4/4] slirp: feature detection for smbd |
Date: |
Tue, 9 Mar 2021 10:11:31 -0800 |
On Tue, Mar 9, 2021 at 6:09 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Hi Joelle,
>
> On 3/9/21 1:27 AM, Joelle van Dyne wrote:
> > Replace Windows specific macro with a more generic feature detection
> > macro. Allows slirp smb feature to be disabled manually as well.
> >
> > Signed-off-by: Joelle van Dyne <j@getutm.app>
> > ---
> > configure | 26 +++++++++++++++++++++++---
> > meson.build | 2 +-
> > net/slirp.c | 16 ++++++++--------
> > 3 files changed, 32 insertions(+), 12 deletions(-)
>
> Hmm v1 had: Acked-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> did you change something to not include Samuel A-b tag?
>
Sorry, I must have missed it!
-j
- [PATCH v2 1/4] block: feature detection for host block support, (continued)