|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() |
Date: | Tue, 9 Mar 2021 12:25:18 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 3/9/21 8:12 AM, Markus Armbruster wrote:
@@ -2565,6 +2551,7 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl, Error **errp) { int i, j; + FDrive *drive; static int command_tables_inited = 0;if (fdctrl->fallback == FLOPPY_DRIVE_TYPE_AUTO) {@@ -2604,7 +2591,13 @@ static void fdctrl_realize_common(DeviceState *dev, FDCtrl *fdctrl, }floppy_bus_create(fdctrl, &fdctrl->bus, dev);- fdctrl_connect_drives(fdctrl, dev, errp); + + for (i = 0; i < MAX_FD; i++) { + drive = &fdctrl->drives[i];
FWIW, the declaration could be local to this loop. r~
[Prev in Thread] | Current Thread | [Next in Thread] |