[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/5] ui: Replace the word 'whitelist'
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v3 1/5] ui: Replace the word 'whitelist' |
Date: |
Tue, 9 Mar 2021 22:13:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Le 03/03/2021 à 19:46, Philippe Mathieu-Daudé a écrit :
> Follow the inclusive terminology from the "Conscious Language in your
> Open Source Projects" guidelines [*] and replace the words "whitelist"
> appropriately.
>
> [*] https://github.com/conscious-lang/conscious-lang-docs/blob/main/faq.md
>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> ui/console.c | 2 +-
> ui/vnc-auth-sasl.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ui/console.c b/ui/console.c
> index c5d11bc7017..5a8311ced20 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -1708,7 +1708,7 @@ bool dpy_gfx_check_format(QemuConsole *con,
> return false;
> }
> } else {
> - /* default is to whitelist native 32 bpp only */
> + /* default is to allow native 32 bpp only */
> if (format != qemu_default_pixman_format(32, true)) {
> return false;
> }
> diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
> index f67111a3662..df7dc08e9fc 100644
> --- a/ui/vnc-auth-sasl.c
> +++ b/ui/vnc-auth-sasl.c
> @@ -288,7 +288,7 @@ static int protocol_client_auth_sasl_step(VncState *vs,
> uint8_t *data, size_t le
> goto authreject;
> }
>
> - /* Check username whitelist ACL */
> + /* Check the username access control list */
> if (vnc_auth_sasl_check_access(vs) < 0) {
> goto authreject;
> }
> @@ -409,7 +409,7 @@ static int protocol_client_auth_sasl_start(VncState *vs,
> uint8_t *data, size_t l
> goto authreject;
> }
>
> - /* Check username whitelist ACL */
> + /* Check the username access control list */
> if (vnc_auth_sasl_check_access(vs) < 0) {
> goto authreject;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
- [PATCH v3 0/5] misc: Replace the words 'blacklist/whitelist', Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v3 1/5] ui: Replace the word 'whitelist', Philippe Mathieu-Daudé, 2021/03/03
- Re: [PATCH v3 1/5] ui: Replace the word 'whitelist',
Laurent Vivier <=
- [PATCH v3 2/5] scripts/tracetool: Replace the word 'whitelist', Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v3 3/5] seccomp: Replace the word 'blacklist', Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v3 4/5] qemu-options: Replace the word 'blacklist', Philippe Mathieu-Daudé, 2021/03/03
- [PATCH v3 5/5] tests/fp/fp-test: Replace the word 'blacklist', Philippe Mathieu-Daudé, 2021/03/03