[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument
From: |
Akihiko Odaki |
Subject: |
Re: [PATCH 2/2] ui/cocoa: Do not rely on the first argument |
Date: |
Thu, 11 Mar 2021 00:49:27 +0900 |
2021年3月10日(水) 21:22 Gerd Hoffmann <kraxel@redhat.com>:
>
> > > > + if (bundle) {
> > >
> > > Does this break about window if the executable is not in a bundle (like
> > > when run from the command line after compiling)? Shouldn't you only put
> > > the qemu_name in this if and have some default name if bundle is not
> > > available (or fall back to argv[0] in that case?
> > >
> > > Regards,
> > > BALATON Zoltan
> > >
> >
> > No, it just doesn't show the application name. Everything else is fine.
>
> Having a fallback would still be nice, even if it is just the fixed
> string "qemu". Starting a fresh build without installing it first is
> common while developing.
>
> take care,
> Gerd
>
It shows "QEMU emulator version %s" just below. Also, it can show the
name even in a build tree without installing so it should be ok.
Regards,
Akihiko Odaki
Re: [PATCH 1/2] ui/cocoa: Show QEMU icon in the about window, Gerd Hoffmann, 2021/03/10