[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] baum: Fix crash when Braille output is not available
From: |
Peter Maydell |
Subject: |
Re: [PATCH] baum: Fix crash when Braille output is not available |
Date: |
Wed, 10 Mar 2021 17:18:11 +0000 |
On Wed, 10 Mar 2021 at 16:08, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
>
> When Braille output is not available, the backend properly reports being
> unable to be created, but 5f8e93c3e262 ("util/qemu-timer: Make timer_free()
> imply timer_del()") made the timer_free() call now refuse any NULL
> parameter. char_braille_finalize thus now has to be more careful with
> calling it on baum->cellCount_timer.
It wasn't the intention of that commit to make freeing a NULL
timer invalid; I think Paolo's patch restoring the ability to
timer_free(NULL) is probably the right thing here:
20210310154526.463850-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210310154526.463850-1-pbonzini@redhat.com/
thanks
-- PMM