[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] usb: remove support for -usbdevice parameters
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/4] usb: remove support for -usbdevice parameters |
Date: |
Wed, 10 Mar 2021 12:19:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/10/21 11:33 AM, Thomas Huth wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> No device needs them anymore and in fact they're undocumented.
> Remove the code. The only change in behavior is that "-usbdevice
> braille:hello" now reports an error, which is a bugfix.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/usb/bus.c | 32 +++++++-------------------------
> hw/usb/dev-serial.c | 2 +-
> include/hw/usb.h | 2 +-
> 3 files changed, 9 insertions(+), 27 deletions(-)
>
> + if (strchr(driver, ':')) {
> + error_report("usbdevice parameters are not supported anymore");
Although wiktionary says it is a valid word in the US, 'anymore' feels
colloquial compared to 'any more'.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH 0/4] Clean up the -usbdevice mess, Thomas Huth, 2021/03/10
- [PATCH 1/4] usb: remove support for -usbdevice parameters, Thomas Huth, 2021/03/10
- Re: [PATCH 1/4] usb: remove support for -usbdevice parameters,
Eric Blake <=
- [PATCH 2/4] usb: remove '-usbdevice u2f-key', Thomas Huth, 2021/03/10
- [PATCH 4/4] usb: Document the missing -usbdevice options, Thomas Huth, 2021/03/10
- [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed), Thomas Huth, 2021/03/10
- Re: [PATCH 3/4] usb: Un-deprecate -usbdevice (except for -usbdevice audio which gets removed), Paolo Bonzini, 2021/03/11
Re: [PATCH 0/4] Clean up the -usbdevice mess, Gerd Hoffmann, 2021/03/11
[PATCH 5/4] usb: Remove "-usbdevice ccid", Thomas Huth, 2021/03/11