[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wordin
From: |
no-reply |
Subject: |
Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording |
Date: |
Thu, 11 Mar 2021 02:45:48 -0800 (PST) |
Patchew URL:
20210311103250.532191-1-pbonzini@redhat.com/">https://patchew.org/QEMU/20210311103250.532191-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210311103250.532191-1-pbonzini@redhat.com
Subject: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20210311103250.532191-1-pbonzini@redhat.com ->
patchew/20210311103250.532191-1-pbonzini@redhat.com
Switched to a new branch 'test'
743512a libvhost-user: rename struct VuDev fields from "slave" to "backend"
d41a226 libvhost-user: rename message names from "SLAVE" to "BACKEND"
50533a6 vhost-user: rename message names from "SLAVE" to "BACKEND"
091c293 docs: vhost-user: rename message names from "SLAVE" to "BACKEND"
522e044 docs: vhost-user: replace master/slave with frontend/backend
a31c678 docs: vhost-user: rewrite section on ring state machine
865d2fb docs: vhost-user: clean up request/reply description
=== OUTPUT BEGIN ===
1/7 Checking commit 865d2fb5c75f (docs: vhost-user: clean up request/reply
description)
2/7 Checking commit a31c678027a2 (docs: vhost-user: rewrite section on ring
state machine)
3/7 Checking commit 522e044c3977 (docs: vhost-user: replace master/slave with
frontend/backend)
4/7 Checking commit 091c293d3260 (docs: vhost-user: rename message names from
"SLAVE" to "BACKEND")
5/7 Checking commit 50533a60dcce (vhost-user: rename message names from "SLAVE"
to "BACKEND")
WARNING: line over 80 characters
#96: FILE: hw/virtio/vhost-user.c:1336:
+ VhostUserVringArea
*area,
ERROR: space prohibited before that ':' (ctx:WxE)
#154: FILE: hw/virtio/vhost-user.c:1466:
+ case VHOST_USER_BACKEND_CONFIG_CHANGE_MSG :
^
total: 1 errors, 1 warnings, 253 lines checked
Patch 5/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit d41a22625345 (libvhost-user: rename message names from
"SLAVE" to "BACKEND")
WARNING: line over 80 characters
#168: FILE: subprojects/libvhost-user/libvhost-user.h:134:
+ VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG =
VHOST_USER_BACKEND_VRING_HOST_NOTIFIER_MSG,
WARNING: line over 80 characters
#179: FILE: subprojects/libvhost-user/libvhost-user.h:313:
+ * size. The backend could get it from queue size field of
VhostUserInflight. */
WARNING: Block comments use a trailing */ on a separate line
#179: FILE: subprojects/libvhost-user/libvhost-user.h:313:
+ * size. The backend could get it from queue size field of
VhostUserInflight. */
total: 0 errors, 3 warnings, 145 lines checked
Patch 6/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/7 Checking commit 743512a20c83 (libvhost-user: rename struct VuDev fields
from "slave" to "backend")
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210311103250.532191-1-pbonzini@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210311103250.532191-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v2 0/7] vhost: replace master/slave with more accurate wording, Paolo Bonzini, 2021/03/11
- [PATCH 2/7] docs: vhost-user: rewrite section on ring state machine, Paolo Bonzini, 2021/03/11
- [PATCH 1/7] docs: vhost-user: clean up request/reply description, Paolo Bonzini, 2021/03/11
- [PATCH 4/7] docs: vhost-user: rename message names from "SLAVE" to "BACKEND", Paolo Bonzini, 2021/03/11
- [PATCH 3/7] docs: vhost-user: replace master/slave with frontend/backend, Paolo Bonzini, 2021/03/11
- [PATCH 5/7] vhost-user: rename message names from "SLAVE" to "BACKEND", Paolo Bonzini, 2021/03/11
- [PATCH 7/7] libvhost-user: rename struct VuDev fields from "slave" to "backend", Paolo Bonzini, 2021/03/11
- [PATCH 6/7] libvhost-user: rename message names from "SLAVE" to "BACKEND", Paolo Bonzini, 2021/03/11
- Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording,
no-reply <=
- Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording, Marc-André Lureau, 2021/03/11
- Re: [PATCH v2 0/7] vhost: replace master/slave with more accurate wording, Stefano Garzarella, 2021/03/12