[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] char: Deprecate backend aliases
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 0/3] char: Deprecate backend aliases |
Date: |
Fri, 12 Mar 2021 09:34:58 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Kevin Wolf <kwolf@redhat.com> writes:
> A small series from November that has fallen through the cracks...
Glad you remembered!
> These aliases only work the command line, but not in QMP. Command line
> QAPIfication involves writing some compatibility glue for them, which
> I'm doing, but I think it's desirable to unify accepted values of both
> paths. So deprecate the aliases so that we can drop the compatibility
> glue later.
>
> v2:
> - Don't mention deprecated options in the help [Markus]
>
> - Added third patch to simplify the code again. Markus had suggested
> not complicating it in the first place, but then I would have to merge
> patches 1 and 2 even though they address different points, so this
> didn't feel very desirable.
Complicated review a bit, but I'm not sure the alternative would've been
easier.
Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks!