[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/27] ui: make gl_block use a counter
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 07/27] ui: make gl_block use a counter |
Date: |
Fri, 12 Mar 2021 11:12:02 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/12/21 11:00 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Track multiple callers blocking requests.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/console.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/ui/console.c b/ui/console.c
> index 53eba2019e..fedb9d8b13 100644
> --- a/ui/console.c
> +++ b/ui/console.c
> @@ -128,7 +128,7 @@ struct QemuConsole {
> DisplaySurface *surface;
> int dcls;
> DisplayChangeListener *gl;
> - bool gl_block;
> + int gl_block;
> int window_id;
>
> /* Graphic console state. */
> @@ -288,10 +288,19 @@ void graphic_hw_gl_block(QemuConsole *con, bool block)
> {
> assert(con != NULL);
>
> - con->gl_block = block;
> - if (con->hw_ops->gl_block) {
> - con->hw_ops->gl_block(con->hw, block);
> + if (block) {
> + con->gl_block++;
> + } else {
> + con->gl_block--;
> + }
> + assert(con->gl_block >= 0);
> + if (!con->hw_ops->gl_block) {
> + return;
> + }
> + if ((block && con->gl_block != 1) || (!block && con->gl_block != 0)) {
Dubious condition check... Could you rewrite it KISS for review?
> + return;
> }
> + con->hw_ops->gl_block(con->hw, block);
> }
>
> void graphic_hw_gl_flushed(QemuConsole *con)
>
- [PATCH 00/27] Add D-Bus display backend, marcandre . lureau, 2021/03/12
- [PATCH 01/27] ui: fold qemu_alloc_display in only caller, marcandre . lureau, 2021/03/12
- [PATCH 02/27] vhost-user-gpu: glFlush before notifying clients, marcandre . lureau, 2021/03/12
- [PATCH 03/27] vhost-user-gpu: fix vugbm_device_init fallback, marcandre . lureau, 2021/03/12
- [PATCH 04/27] vhost-user-gpu: fix cursor move/update, marcandre . lureau, 2021/03/12
- [PATCH 05/27] ui: factor out qemu_console_set_display_gl_ctx(), marcandre . lureau, 2021/03/12
- [PATCH 06/27] ui: associate GL context outside of display listener registration, marcandre . lureau, 2021/03/12
- [PATCH 07/27] ui: make gl_block use a counter, marcandre . lureau, 2021/03/12
- Re: [PATCH 07/27] ui: make gl_block use a counter,
Philippe Mathieu-Daudé <=
- [PATCH 08/27] ui: add a gl-unblock warning timer, marcandre . lureau, 2021/03/12
- [PATCH 09/27] ui: simplify gl unblock & flush, marcandre . lureau, 2021/03/12
- [PATCH 10/27] ui: dispatch GL events to all listeners, marcandre . lureau, 2021/03/12
- [PATCH 11/27] ui: split the GL context in a different object, marcandre . lureau, 2021/03/12
- [PATCH 12/27] ui: move qemu_spice_fill_device_address to ui/util.c, marcandre . lureau, 2021/03/12
- [PATCH 13/27] console: save current scanout details, marcandre . lureau, 2021/03/12
- [PATCH 14/27] ui: add a D-Bus display backend, marcandre . lureau, 2021/03/12