qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Virtio-fs] [PATCH 2/3] virtiofsd: Convert some functions to return


From: Connor Kuehl
Subject: Re: [Virtio-fs] [PATCH 2/3] virtiofsd: Convert some functions to return bool
Date: Fri, 12 Mar 2021 09:13:39 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 3/12/21 8:10 AM, Greg Kurz wrote:
Both currently only return 0 or 1.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
  tools/virtiofsd/passthrough_ll.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index 27a6c636dcaf..f63016d35626 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -221,17 +221,17 @@ static struct lo_inode *lo_find(struct lo_data *lo, 
struct stat *st,
  static int xattr_map_client(const struct lo_data *lo, const char *client_name,
                              char **out_name);
-static int is_dot_or_dotdot(const char *name)
+static bool is_dot_or_dotdot(const char *name)
  {
      return name[0] == '.' &&
             (name[1] == '\0' || (name[1] == '.' && name[2] == '\0'));
  }
/* Is `path` a single path component that is not "." or ".."? */
-static int is_safe_path_component(const char *path)
+static bool is_safe_path_component(const char *path)
  {
      if (strchr(path, '/')) {
-        return 0;
+        return false;
      }
return !is_dot_or_dotdot(path);


Reviewed-by: Connor Kuehl <ckuehl@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]