[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPI
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it |
Date: |
Sat, 13 Mar 2021 13:32:22 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 13/03/21 10:35, Markus Armbruster wrote:
>>> + object_option_foreach_add(object_create_late, &error_fatal);
>> Likewise.
>>
>> Before and after the patch, object_create_late(opt) ==
>> !object_create_early(opt). Your patch provides us with an opportunity
>> to assert this: object_opts must be empty now. Suggestion, not demand.
>>
>
> Nice idea, I'll include it.
Possible alternative:
static bool object_create_late(const char *type)
{
return true;
}
Your choice.